Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

Cherry pick TextureView#10370

Merged
tobrun merged 6 commits into
release-aguafrom
tvn-cherry-pick-textureview
Nov 3, 2017
Merged

Cherry pick TextureView#10370
tobrun merged 6 commits into
release-aguafrom
tvn-cherry-pick-textureview

Conversation

@tobrun
Copy link
Copy Markdown
Member

@tobrun tobrun commented Nov 2, 2017

@ivovandongen I went ahead and cherry picked your TextureView commits from #10334 to the release branch. I'm using this branch as a base to do some AWS device farm tests.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Nov 2, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Nov 2, 2017
@tobrun tobrun self-assigned this Nov 2, 2017
@tobrun tobrun requested a review from ivovandongen November 2, 2017 20:58
@tobrun tobrun force-pushed the tvn-cherry-pick-textureview branch from 7124963 to 04ac363 Compare November 2, 2017 22:00
@tobrun
Copy link
Copy Markdown
Member Author

tobrun commented Nov 2, 2017

@ivovandongen I ran this branch on ~30 devices, validated rendering and not seeing any issues.

@tobrun
Copy link
Copy Markdown
Member Author

tobrun commented Nov 2, 2017

the tests are failing with:

java.lang.RuntimeException: eglDestroyContext: 12301
FATAL EXCEPTION: Thread-1691
Process: com.mapbox.mapboxsdk.testapp, PID: 14196
java.lang.RuntimeException: eglDestroyContext: 12301
	at com.mapbox.mapboxsdk.maps.renderer.textureview.TextureViewRenderThread$EGLHolder.destroySurface(TextureViewRenderThread.java:412)
	at com.mapbox.mapboxsdk.maps.renderer.textureview.TextureViewRenderThread$EGLHolder.cleanup(TextureViewRenderThread.java:437)
	at com.mapbox.mapboxsdk.maps.renderer.textureview.TextureViewRenderThread.run(TextureViewRenderThread.java:300)

@ivovandongen
Copy link
Copy Markdown
Contributor

ivovandongen commented Nov 3, 2017

@tobrun Fixed the cleanup code here: #10376. Add this to this PR please.

@lilykaiser lilykaiser added the beta blocker Blocks the next beta release label Nov 3, 2017
@tobrun tobrun merged commit d1d0c20 into release-agua Nov 3, 2017
@tobrun tobrun deleted the tvn-cherry-pick-textureview branch November 3, 2017 16:19
@tobrun tobrun mentioned this pull request Nov 3, 2017
Closed
21 tasks
This was referenced Nov 14, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ivovandongen ivovandongen Awaiting requested review from ivovandongen

1 more reviewer

@zugaldia zugaldia zugaldia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tobrun tobrun

Labels

Android Mapbox Maps SDK for Android beta blocker Blocks the next beta release

Projects

None yet

Milestone

android-v5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tobrun @ivovandongen @zugaldia @lilykaiser